I don't think he always folds a worse hand on the flop. A lower flush not only is pretty uncommon but pretty hard to lay down on a 3-flush board. Also, I think only a pretty weak (as in conservative, not weak as in bad) player lays down a flopped straight here as well.

You are ahead 90% of the time here, and likely hands (high f/d, set) have significant outs against you. That's why you raise - for value and to kill drawing odds, not to get information.

If you re-raise and get called then there are a bunch of scare cards (4th hearts/board pairs) that mandate you check/calling or even folding to heavy action from both opps. If the turn is a brick... you have a choice to make based on reads. You are out of position, and have shown extreme strength (re-raising flop) on a scary board. You can lead out, perhaps getting folds you don't want, or raises (which are going to scare you), but it's consistant. Or you can check - you might give a free card here, but since you have to shut down on a scary river, that's not that bad. You might entice a small bet from a better hand, or a bluff.

It's not an easy hand to play - for sure - and I think very read dependent. I'm not saying calling the flop raise and check/calling to the river is bad, and in fact worked out OK for you - but I am pretty confident that re-raising here isn't "always bad" like you stated.